Skip to content

utils.RunUnderSystemdScope(): always close Conn#11313

Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom
nalind:leaked-bus-connection
Aug 24, 2021
Merged

utils.RunUnderSystemdScope(): always close Conn#11313
openshift-merge-robot merged 1 commit intocontainers:mainfrom
nalind:leaked-bus-connection

Conversation

@nalind
Copy link
Member

@nalind nalind commented Aug 23, 2021

Make sure we close our private connection to the bus, even if we're not successful in in using it to ask systemd to move a unit's processes to a specific control group.

@nalind
utils.RunUnderSystemdScope(): always close Conn
02e59c6 
Make sure we close our private connection to the bus, even if we're not
successful in in using it to ask systemd to move a unit's processes to a
specific control group.

[NO TESTS NEEDED]

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind
Copy link
Member Author

nalind commented Aug 24, 2021

Ran into this while attempting to debug #11263. The symptom is that podman opens connections to the system bus daemon until the system bus daemon determines that it's exceeded the per-UID limit on active connections to the bus daemon (default is 256), and starts refusing new connections from the invoking user (i.e., root). Then podman starts relaying back errors from crun that look like sd-bus call: No buffer space available because crun can't contact the system bus, either.

vrothberg
vrothberg reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, LGTM

@Luap99 PTAL

@Luap99
Copy link
Member

Luap99 commented Aug 24, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2021
@Luap99
Copy link
Member

Luap99 commented Aug 24, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit eb9d731 into containers:main Aug 24, 2021
@nalind nalind deleted the leaked-bus-connection branch August 24, 2021 12:23
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vrothberg vrothberg vrothberg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Luap99 Luap99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nalind @Luap99 @vrothberg @openshift-merge-robot